launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:webtest-2.0.35 into launchpad:master.

Commit message:
Upgrade to WebTest 2.0.35

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/385369

We no longer need to patch in a fix for <input type="search" />.

Dependencies MP: https://code.launchpad.net/~cjwatson/lp-source-dependencies/+git/lp-source-dependencies/+merge/385368
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:webtest-2.0.35 into launchpad:master.

diff --git a/constraints.txt b/constraints.txt
index b5f1806..725b66e 100644
--- a/constraints.txt
+++ b/constraints.txt
@@ -318,7 +318,7 @@ wadllib==1.3.2
 waitress==1.3.1
 webencodings==0.5.1
 WebOb==1.8.5
-WebTest==2.0.33
+WebTest==2.0.35
 wsgi-intercept==1.9.2
 WSGIProxy2==0.4.6
 wsgiref==0.1.2
diff --git a/lib/lp/testing/pages.py b/lib/lp/testing/pages.py
index 6fddbc1..63c7527 100644
--- a/lib/lp/testing/pages.py
+++ b/lib/lp/testing/pages.py
@@ -38,10 +38,7 @@ import six
 from six.moves.urllib.parse import urljoin
 from soupsieve import escape as css_escape
 import transaction
-from webtest import (
-    forms,
-    TestRequest,
-    )
+from webtest import TestRequest
 from zope.app.wsgi.testlayer import (
     FakeResponse as _FakeResponse,
     NotInBrowserLayer,
@@ -104,11 +101,6 @@ SAMPLEDATA_ACCESS_SECRETS = {
     }
 
 
-# Teach WebTest about <input type="search" />.
-# https://github.com/Pylons/webtest/pull/219
-forms.Field.classes['search'] = forms.Text
-
-
 class FakeResponse(_FakeResponse):
     """A fake response for use in tests.