launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/code/model/gitrepository.py b/lib/lp/code/model/gitrepository.py
> index 2e9080f..0421884 100644
> --- a/lib/lp/code/model/gitrepository.py
> +++ b/lib/lp/code/model/gitrepository.py
> @@ -351,6 +355,8 @@ class GitRepository(StormBase, WebhookTargetMixin, GitIdentityMixin):
>              assert IDistribution.providedBy(target.pillar)
>              self.ociprojectname = target.ociprojectname
>              self.distribution = target.pillar
> +        self.status = (status if status is not None
> +                       else GitRepositoryStatus.AVAILABLE)

Oh, I misread and thought you had notNull=False there, in which case it'd need to be changed to True later, but you already correctly have notNull=True.  Disregard that part of my comment.

>          self.owner_default = False
>          self.target_default = False
>  


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/385208
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:gitrepo-status into launchpad:master.