launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:testfix-stormify-translationimportqueueentry into launchpad:master.

Commit message:
Fix TestProduct.test_checkInformationType_queued_translations

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/385680

entry.delete(entry.id) is a SQLObject-ism; use Store.of(entry).remove(entry) instead.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:testfix-stormify-translationimportqueueentry into launchpad:master.

diff --git a/lib/lp/registry/tests/test_product.py b/lib/lp/registry/tests/test_product.py
index 61442a4..e70fbbc 100644
--- a/lib/lp/registry/tests/test_product.py
+++ b/lib/lp/registry/tests/test_product.py
@@ -587,7 +587,7 @@ class TestProduct(TestCaseWithFactory):
                 CannotChangeInformationType,
                 'This project has queued translations.'):
                 raise error
-        removeSecurityProxy(entry).delete(entry.id)
+        Store.of(entry).remove(entry)
         with person_logged_in(product.owner):
             for info_type in PRIVATE_PROJECT_TYPES:
                 self.assertContentEqual(