launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~twom/launchpad:export-git-id-on-api into launchpad:master

To: Tom Wardill <tom.wardill@xxxxxxxxxxxxx>
From: "Thiago F. Pappacena" <pappacena@xxxxxxxxx>
Date: Fri, 12 Jun 2020 17:42:32 -0000
In-reply-to: <159198128196.17968.8708957242939767765.launchpad@ackee.canonical.com>
Reply-to: mp+385683@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I guess we have some webservice tests at lp.code.model.tests.test_gitrepository.TestGitRepositoryWebservice. It would be nice to add the check for the new attribute in at least one of the tests (assertNewWorks method, for example, is used by 3 different test cases and it seems to be easy to add the check there).
-- 
https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/385683
Your team Launchpad code reviewers is requested to review the proposed merge of ~twom/launchpad:export-git-id-on-api into launchpad:master.

References

[Merge] ~twom/launchpad:export-git-id-on-api into launchpad:master
From: Tom Wardill, 2020-06-12