launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-functools-reduce into launchpad:master.

Commit message:
Import reduce from functools

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/386708

Python 3 no longer has reduce as a builtin.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-functools-reduce into launchpad:master.

diff --git a/lib/lp/blueprints/model/specificationsearch.py b/lib/lp/blueprints/model/specificationsearch.py
index a0aed9a..4f68ba6 100644
--- a/lib/lp/blueprints/model/specificationsearch.py
+++ b/lib/lp/blueprints/model/specificationsearch.py
@@ -12,6 +12,7 @@ __all__ = [
     ]
 
 from collections import defaultdict
+from functools import reduce
 
 from storm.expr import (
     And,
diff --git a/lib/lp/bugs/model/bugtasksearch.py b/lib/lp/bugs/model/bugtasksearch.py
index 39c5cb8..334cd6a 100644
--- a/lib/lp/bugs/model/bugtasksearch.py
+++ b/lib/lp/bugs/model/bugtasksearch.py
@@ -11,6 +11,8 @@ __all__ = [
     'search_bugs',
     ]
 
+from functools import reduce
+
 from lazr.enum import BaseItem
 from storm.expr import (
     Alias,
diff --git a/lib/lp/services/webapp/batching.py b/lib/lp/services/webapp/batching.py
index ce4d3ea..2eb6522 100644
--- a/lib/lp/services/webapp/batching.py
+++ b/lib/lp/services/webapp/batching.py
@@ -4,6 +4,7 @@
 __metaclass__ = type
 
 from datetime import datetime
+from functools import reduce
 import re
 
 from iso8601 import (
diff --git a/lib/lp/translations/browser/translationimportqueue.py b/lib/lp/translations/browser/translationimportqueue.py
index 818c751..290a1b5 100644
--- a/lib/lp/translations/browser/translationimportqueue.py
+++ b/lib/lp/translations/browser/translationimportqueue.py
@@ -13,6 +13,7 @@ __all__ = [
     'TranslationImportQueueView',
     ]
 
+from functools import reduce
 import os
 
 from lazr.restful.interface import copy_field