launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Diff comments:

> diff --git a/Makefile b/Makefile
> index ad76c8f..cffb8e3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -98,6 +104,24 @@ run-api: $(ENV)
>  run-pack: $(ENV)
>  	$(PYTHON) turnipserver.py
>  
> +run-worker: $(ENV)
> +	PYTHONPATH="turnip" $(CELERY) -A tasks worker \
> +		--loglevel=info \
> +		--concurrency=20 \
> +		--pool=gevent

I still need to test if gevent is a feasible option here. In particular because we do use pygit a lot, and it will probably not be cooperative enough.

> +
> +run:
> +	make run-api &\
> +	make run-pack &\
> +	make run-worker&\
> +	wait;
> +
> +stop:
> +	-pkill -f 'make run-api'
> +	-pkill -f 'make run-pack'
> +	-pkill -f 'make run-worker'
> +	-pkill -f '$(CELERY) -A tasks worker'
> +
>  $(PIP_CACHE): $(ENV)
>  	mkdir -p $(PIP_CACHE)
>  	$(PIP) install $(PIP_ARGS) -d $(PIP_CACHE) \


-- 
https://code.launchpad.net/~pappacena/turnip/+git/turnip/+merge/387252
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/turnip:celery-repo-creation into turnip:master.