launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/launchpad_loggerhead/session.py b/lib/launchpad_loggerhead/session.py
> index cf4516b..3792487 100644
> --- a/lib/launchpad_loggerhead/session.py
> +++ b/lib/launchpad_loggerhead/session.py
> @@ -62,5 +64,7 @@ class SessionHandler(object):
>              # of the request.
>              if existed or session:
>                  environ[self.session_var] = pickle.dumps(session)
> +            response_headers.append(
> +                ('X-Launchpad-Revision', versioninfo.revision))

This will work, but it doesn't seem very much associated with the session cookie management.  Could you move it to its own middleware?  The stack is assembled in launchpad_loggerhead.wsgi.

>              return start_response(status, response_headers, exc_info)
>          return self.application(environ, response_hook)


-- 
https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/387505
Your team Launchpad code reviewers is requested to review the proposed merge of ~twom/launchpad:add-revision-header-to-loggerhead into launchpad:master.