launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-amp-commands into launchpad:master.

Commit message:
Make RunJobCommand argument and response names bytes

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/387773

This is required in Python 3.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-amp-commands into launchpad:master.

diff --git a/lib/lp/services/job/runner.py b/lib/lp/services/job/runner.py
index 8f80294..9ac7863 100644
--- a/lib/lp/services/job/runner.py
+++ b/lib/lp/services/job/runner.py
@@ -426,8 +426,8 @@ class JobRunner(BaseJobRunner):
 
 class RunJobCommand(amp.Command):
 
-    arguments = [('job_id', amp.Integer())]
-    response = [('success', amp.Integer()), ('oops_id', amp.String())]
+    arguments = [(b'job_id', amp.Integer())]
+    response = [(b'success', amp.Integer()), (b'oops_id', amp.String())]
 
 
 def import_source(job_source_name):