launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:db-drop-gpgkey-fks into launchpad:db-devel.

Commit message:
Drop obsolete GPGKey foreign keys

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers): db

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/388674

These have all been replaced with corresponding signing_key_owner/signing_key_fingerprint pairs.

https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/388586 needs to land on production first.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:db-drop-gpgkey-fks into launchpad:db-devel.

diff --git a/database/schema/comments.sql b/database/schema/comments.sql
index 0c46b19..99af160 100644
--- a/database/schema/comments.sql
+++ b/database/schema/comments.sql
@@ -1353,10 +1353,6 @@ COMMENT ON COLUMN SourcePackageRelease.urgency IS 'The urgency of the
 upload. This is generally used to prioritise buildd activity but may also be
 used for "testing" systems or security work in the future. The "urgency" is
 set by the uploader, in the DSC file.';
-COMMENT ON COLUMN SourcePackageRelease.dscsigningkey IS 'The GPG key used to
-sign the DSC. This is not necessarily the maintainer''s key, or the
-creator''s key. For example, it''s possible to produce a package, then ask a
-sponsor to upload it.';
 COMMENT ON COLUMN SourcePackageRelease.component IS 'The component in which
 this sourcepackagerelease is intended (by the uploader) to reside. E.g.
 main, universe, restricted. Note that the distribution managers will often
@@ -1921,7 +1917,6 @@ COMMENT ON COLUMN Archive.pending_count IS 'How many packages still need buildin
 COMMENT ON COLUMN Archive.succeeded_count IS 'How many source packages were built sucessfully?';
 COMMENT ON COLUMN Archive.failed_count IS 'How many packages failed to build?';
 COMMENT ON COLUMN Archive.building_count IS 'How many packages are building at present?';
-COMMENT ON COLUMN Archive.signing_key IS 'The GpgKey used for signing this archive.';
 COMMENT ON COLUMN Archive.removed_binary_retention_days IS 'The number of days before superseded or deleted binary files are expired in the librarian, or zero for never.';
 COMMENT ON COLUMN Archive.num_old_versions_published IS 'The number of versions of a package to keep published before older versions are superseded.';
 COMMENT ON COLUMN Archive.relative_build_score IS 'A delta to the build score that is applied to all builds in this archive.';
diff --git a/database/schema/patch-2210-19-0.sql b/database/schema/patch-2210-19-0.sql
new file mode 100644
index 0000000..e380a3a
--- /dev/null
+++ b/database/schema/patch-2210-19-0.sql
@@ -0,0 +1,13 @@
+
+-- Copyright 2020 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE Archive DROP COLUMN signing_key;
+ALTER TABLE PackageUpload DROP COLUMN signing_key;
+ALTER TABLE Revision DROP COLUMN gpgkey;
+ALTER TABLE SignedCodeOfConduct DROP COLUMN signingkey;
+ALTER TABLE SourcePackageRelease DROP COLUMN dscsigningkey;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 19, 0);