launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-packagebuild-bytesio into launchpad:master.

Commit message:
Convert PackageBuildMixin to BytesIO

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/389439
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-packagebuild-bytesio into launchpad:master.

diff --git a/lib/lp/buildmaster/model/packagebuild.py b/lib/lp/buildmaster/model/packagebuild.py
index 9c61291..46f996e 100644
--- a/lib/lp/buildmaster/model/packagebuild.py
+++ b/lib/lp/buildmaster/model/packagebuild.py
@@ -7,7 +7,7 @@ __all__ = [
     ]
 
 
-from cStringIO import StringIO
+from io import BytesIO
 
 import six
 from zope.component import getUtility
@@ -85,7 +85,7 @@ class PackageBuildMixin(BuildFarmJobMixin):
         contentType = filenameToContentType(filename)
         content = six.ensure_binary(content)
         file_size = len(content)
-        file_content = StringIO(content)
+        file_content = BytesIO(content)
         restricted = self.is_private
 
         return getUtility(ILibraryFileAliasSet).create(