launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #25187
[Merge] ~cjwatson/launchpad:testfix-signing-service-client-fixture into launchpad:master
Colin Watson has proposed merging ~cjwatson/launchpad:testfix-signing-service-client-fixture into launchpad:master.
Commit message:
Fix signature of SigningServiceClientFixture._generate
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/389464
--
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:testfix-signing-service-client-fixture into launchpad:master.
diff --git a/lib/lp/services/signing/tests/helpers.py b/lib/lp/services/signing/tests/helpers.py
index 447f62c..339c4f9 100644
--- a/lib/lp/services/signing/tests/helpers.py
+++ b/lib/lp/services/signing/tests/helpers.py
@@ -45,7 +45,8 @@ class SigningServiceClientFixture(fixtures.Fixture):
self.sign_returns = []
self.inject_returns = []
- def _generate(self, key_type, description):
+ def _generate(self, key_type, description,
+ openpgp_key_algorithm=None, length=None):
key = bytes(PrivateKey.generate().public_key)
data = {
"fingerprint": self.factory.getUniqueHexString(40),