launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #25195
Re: [Merge] ~pappacena/turnip/+git/turnip-dependencies:twisted-ssh-env-var into ~canonical-launchpad-branches/turnip/+git/dependencies:master
Diff comments:
> diff --git a/Twisted-20.3.0-pr1173.zip b/Twisted-20.3.0-pr1173.zip
Could we call this 20.3.0+lp1, please? That (a) fits https://www.python.org/dev/peps/pep-0440/#local-version-identifiers and (b) means that if we have to do further backports in future then we aren't in an awkward situation.
I'd also prefer that we used a .tar.bz2, to match the archive format used for Twisted 20.3.0 at the moment.
> new file mode 100644
> index 0000000..db782d1
> Binary files /dev/null and b/Twisted-20.3.0-pr1173.zip differ
--
https://code.launchpad.net/~pappacena/turnip/+git/turnip-dependencies/+merge/389506
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/turnip/+git/turnip-dependencies:twisted-ssh-env-var into ~canonical-launchpad-branches/turnip/+git/dependencies:master.
References