launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/launchpad:db-ocirecipe-args into launchpad:db-devel.

Commit message:
Database changes to support build ARG parameters when building OCI recipes

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/389748

This field will be mapped on OCIRecipe.build_args as a JSON field. It should be an uni-dimensional dict with the arguments that ultimately will be used to add `--build-arg VARIABLE=value` to `docker build` command on the builders.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:db-ocirecipe-args into launchpad:db-devel.

diff --git a/database/schema/patch-2210-20-1.sql b/database/schema/patch-2210-20-1.sql
new file mode 100644
index 0000000..db60c80
--- /dev/null
+++ b/database/schema/patch-2210-20-1.sql
@@ -0,0 +1,10 @@
+-- Copyright 2020 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE OCIRecipe ADD COLUMN build_args text;
+
+COMMENT ON COLUMN OCIRecipe.build_args IS 'ARGs to be used when building the OCI Recipe.';
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 20, 1);