launchpad-reviewers team mailing list archive

[Tom Wardill <tom.wardill@xxxxxxxxxxxxx>]

Tom Wardill has proposed merging ~twom/launchpad:loggerhead-default-interface into launchpad:master.

Commit message:
Change developer codehosting interface to 0.0.0.0

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/390621

We recommend running launchpad in a container now, so it's useful to be able to push bazaar branches from outside the container.
Make the default interface be 0.0.0.0 as it's one less step to making it work as a developer and one less diff that everyone has to carry.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~twom/launchpad:loggerhead-default-interface into launchpad:master.

diff --git a/configs/development/launchpad-lazr.conf b/configs/development/launchpad-lazr.conf
index b8f2c55..a4956f3 100644
--- a/configs/development/launchpad-lazr.conf
+++ b/configs/development/launchpad-lazr.conf
@@ -42,7 +42,7 @@ internal_branch_by_id_root: http://bazaar-internal.launchpad.test/
 internal_codebrowse_root: http://localhost:8080/
 rewrite_script_log_file: /var/tmp/bazaar.launchpad.test/rewrite.log
 host_key_pair_path: lib/lp/codehosting/sshserver/tests/keys
-port: tcp:5022:interface=127.0.0.88
+port: tcp:5022:interface=0.0.0.0
 bzr_lp_prefix: lp://dev/
 lp_url_hosts: dev
 access_log: /var/tmp/bazaar.launchpad.test/codehosting-access.log