launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-command-spawner into launchpad:master.

Commit message:
Handle Python 3-style dict.keys in CommandSpawner.communicate

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/391263
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-command-spawner into launchpad:master.

diff --git a/lib/lp/services/command_spawner.py b/lib/lp/services/command_spawner.py
index 539a3fb..988110c 100644
--- a/lib/lp/services/command_spawner.py
+++ b/lib/lp/services/command_spawner.py
@@ -127,7 +127,7 @@ class CommandSpawner:
 
         # Iterate over a copy of the processes list: we may be removing
         # items from the original as processes complete.
-        processes = self.running_processes.keys()
+        processes = list(self.running_processes)
         for process in processes:
             self._service(process, events_by_fd)
             if process.returncode is not None: