← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~pappacena/launchpad:oci-multi-arch-upload into launchpad:master

 


Diff comments:

> diff --git a/lib/lp/oci/model/ociregistryclient.py b/lib/lp/oci/model/ociregistryclient.py
> index 7561267..55f61ce 100644
> --- a/lib/lp/oci/model/ociregistryclient.py
> +++ b/lib/lp/oci/model/ociregistryclient.py
> @@ -445,5 +515,6 @@ class BearerTokenRegistryClient(RegistryHTTPClient):
>              if auth_retry and e.response.status_code == 401:
>                  self.authenticate(e.response)
>                  return self.request(
> -                    url, auth_retry=False, *args, **request_kwargs)
> +                    url, auth_retry=False, headers=headers,

This is actually a bugfix: the first retried request after authentication was not sending the headers.

> +                    *args, **request_kwargs)
>              raise


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/391783
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:oci-multi-arch-upload into launchpad:master.


References