launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-customupload-bytesio into launchpad:master.

Commit message:
Port lp.archivepublisher.tests.test_customupload to io.BytesIO

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/392059
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-customupload-bytesio into launchpad:master.

diff --git a/lib/lp/archivepublisher/tests/test_customupload.py b/lib/lp/archivepublisher/tests/test_customupload.py
index a1d1f45..a9b1173 100644
--- a/lib/lp/archivepublisher/tests/test_customupload.py
+++ b/lib/lp/archivepublisher/tests/test_customupload.py
@@ -8,7 +8,7 @@ from __future__ import absolute_import, print_function, unicode_literals
 __metaclass__ = type
 
 
-import cStringIO
+import io
 import os
 import shutil
 import tarfile
@@ -115,7 +115,7 @@ class TestTarfileVerification(TestCase):
         self.custom_processor.tarfile_path = self.tarfile_name
 
     def createTarfile(self):
-        self.tar_fileobj = cStringIO.StringIO()
+        self.tar_fileobj = io.BytesIO()
         tar_file = tarfile.open(name=None, mode="w", fileobj=self.tar_fileobj)
         root_info = tarfile.TarInfo(name='./')
         root_info.type = tarfile.DIRTYPE