← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~cjwatson/launchpad:testfix-stormify-distroserieslanguage into launchpad:master

 

Colin Watson has proposed merging ~cjwatson/launchpad:testfix-stormify-distroserieslanguage into launchpad:master.

Commit message:
Revert incorrect change to distroseries-translations.pt

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/392307

When converting DistroSeriesLanguage to Storm, I confused DistroSeries.distroserieslanguages with DistroSeriesView.distroserieslanguages.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:testfix-stormify-distroserieslanguage into launchpad:master.
diff --git a/lib/lp/translations/templates/distroseries-translations.pt b/lib/lp/translations/templates/distroseries-translations.pt
index 43c72b4..8592c4e 100644
--- a/lib/lp/translations/templates/distroseries-translations.pt
+++ b/lib/lp/translations/templates/distroseries-translations.pt
@@ -139,7 +139,7 @@
             </div>
           </div>
         </div>
-        <tal:stats condition="not: view/distroserieslanguages/is_empty">
+        <tal:stats condition="view/distroserieslanguages">
           <div class="yui-b top-portlet">
             <h2>Translation statistics</h2>
             <div tal:replace="structure context/@@+langchart" />