launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #25503
[Merge] ~cjwatson/launchpad:testfix-stormify-archivedependency into launchpad:master
Colin Watson has proposed merging ~cjwatson/launchpad:testfix-stormify-archivedependency into launchpad:master.
Commit message:
Adjust archive-index.pt for ArchiveDependency Storm conversion
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/392330
Archive.dependencies now returns a ResultSet rather than a SQLObjectResultSet.
Fixes lib/lp/soyuz/stories/ppa/xx-edit-dependencies.txt and lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt test failures caused by https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/392161.
--
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:testfix-stormify-archivedependency into launchpad:master.
diff --git a/lib/lp/soyuz/templates/archive-index.pt b/lib/lp/soyuz/templates/archive-index.pt
index 9a83a85..d67a632 100644
--- a/lib/lp/soyuz/templates/archive-index.pt
+++ b/lib/lp/soyuz/templates/archive-index.pt
@@ -120,7 +120,7 @@ sudo apt-get update
<dd tal:content="signing_key/fingerprint"/>
</dl>
<div id="archive-dependencies"
- tal:condition="context/dependencies">
+ tal:condition="not: context/dependencies/is_empty">
<h3>Dependencies:</h3>
<ul>
<li tal:repeat="dependency context/dependencies">