launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-testregistration-bytesio into launchpad:master.

Commit message:
Port TestRegistration to io.BytesIO

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/392387
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-testregistration-bytesio into launchpad:master.

diff --git a/lib/lp/translations/tests/test_publisher.py b/lib/lp/translations/tests/test_publisher.py
index 576961a..235f8e4 100644
--- a/lib/lp/translations/tests/test_publisher.py
+++ b/lib/lp/translations/tests/test_publisher.py
@@ -5,7 +5,7 @@
 
 __metaclass__ = type
 
-import StringIO
+import io
 
 from lp.layers import WebServiceLayer
 from lp.services.config import config
@@ -44,7 +44,7 @@ class TestRegistration(TestCase):
     def test_response_should_vary_based_on_language(self):
         # Responses to requests to translations pages have the 'Vary' header
         # set to include Accept-Language.
-        request = TranslationsBrowserRequest(StringIO.StringIO(''), {})
+        request = TranslationsBrowserRequest(io.BytesIO(), {})
         self.assertEqual(
             request.response.getHeader('Vary'),
             'Cookie, Authorization, Accept-Language')