launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:testfix-loosen-valid-email into launchpad:master.

Commit message:
Use a more convincingly invalid address in TestSignableTagFile

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/393072

Fixes test failure in lp.archiveuploader.tests.test_dscfile.TestSignableTagFile.test_parseAddress_raises_UploadError_if_address_is_malformed.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:testfix-loosen-valid-email into launchpad:master.

diff --git a/lib/lp/archiveuploader/tests/test_dscfile.py b/lib/lp/archiveuploader/tests/test_dscfile.py
index de5f2ff..a82aa6b 100644
--- a/lib/lp/archiveuploader/tests/test_dscfile.py
+++ b/lib/lp/archiveuploader/tests/test_dscfile.py
@@ -188,7 +188,7 @@ class TestSignableTagFile(TestCaseWithFactory):
     def test_parseAddress_raises_UploadError_if_address_is_malformed(self):
         self.assertRaises(
             UploadError,
-            self.makeSignableTagFile().parseAddress, "invalid@bad-address")
+            self.makeSignableTagFile().parseAddress, "invalid@bad@address")
 
     def test_parseAddress_decodes_utf8(self):
         name = u'B\u0105r'