launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

The changes are all related to BugTask refactoring. Mostly:

- Using StormBase instead of SQLBase class;

- Renaming the foreign key ID attributes to match newer pattern ("foreignkey_id", instead of "foreignKeyID"). This change itself is responsible for most of the lines changed, since there were queries across the code base using BugTask attributes (like BugTask.bugID, BugTask.assigneeID, etc);

- Refactoring of the `validate_conjoined_attribute` method to keep track of the changed attributes separately, on `BugTask.passthrough_attrs` dict; currently, we are setting a `PassthroughValue` object wrapper in some attributes, but Storm doesn't allow it (an `Int` attribute only accepts ints, for example).

- Replacing `BugTask.get(id)` with `getUtility(BugTaskSet).get(id)`;

- Changing `BugTask.select`/`BugTask.selectBy` with `store.find(BugTask, ...)`
-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/393473
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:stormify-bug-task into launchpad:master.