launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/turnip:py3-binary-large-test-file into turnip:master.

Commit message:
Write large test file as binary

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/turnip/+git/turnip/+merge/393767
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/turnip:py3-binary-large-test-file into turnip:master.

diff --git a/turnip/pack/tests/test_functional.py b/turnip/pack/tests/test_functional.py
index 4e5cbf2..97a99d2 100644
--- a/turnip/pack/tests/test_functional.py
+++ b/turnip/pack/tests/test_functional.py
@@ -532,7 +532,7 @@ class FunctionalTestMixin(WithScenarios):
         yield self.assertCommandSuccess(
             (b'git', b'config', b'user.email', b'test@xxxxxxxxxxx'),
             path=clone1)
-        with open(os.path.join(clone1, 'bigfile'), 'w') as bigfile:
+        with open(os.path.join(clone1, 'bigfile'), 'wb') as bigfile:
             # Use random contents to defeat compression.
             bigfile.write(bytearray(
                 random.getrandbits(8) for _ in range(1024 * 1024)))