launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-getUniqueEmailAddress-unicode into launchpad:master.

Commit message:
Make getUniqueEmailAddress return Unicode

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/393771

This is a better default.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-getUniqueEmailAddress-unicode into launchpad:master.

diff --git a/lib/lp/testing/factory.py b/lib/lp/testing/factory.py
index 57babc5..b2cf34f 100644
--- a/lib/lp/testing/factory.py
+++ b/lib/lp/testing/factory.py
@@ -435,7 +435,7 @@ class ObjectFactory(
     _unique_int_counter = count(100000)
 
     def getUniqueEmailAddress(self):
-        return "%s@xxxxxxxxxxx" % self.getUniqueString('email')
+        return "%s@xxxxxxxxxxx" % self.getUniqueUnicode('email')
 
     def getUniqueInteger(self):
         """Return an integer unique to this factory instance.