launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-makePackageDiff-bytes into launchpad:master.

Commit message:
Fix makePackageDiff for Python 3

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/393781

The diff content should be bytes, not text.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-makePackageDiff-bytes into launchpad:master.

diff --git a/lib/lp/testing/factory.py b/lib/lp/testing/factory.py
index b2cf34f..14e917d 100644
--- a/lib/lp/testing/factory.py
+++ b/lib/lp/testing/factory.py
@@ -4490,7 +4490,7 @@ class BareLaunchpadObjectFactory(ObjectFactory):
         if date_fulfilled is None:
             date_fulfilled = UTC_NOW
         if diff_content is None:
-            diff_content = self.getUniqueString("packagediff")
+            diff_content = self.getUniqueBytes("packagediff")
         lfa = self.makeLibraryFileAlias(
             filename=diff_filename, content=diff_content)
         return ProxyFactory(