launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/turnip:partial-py3-tests-runner into turnip:master.

Commit message:
Avoid regressions on python3 migration when adding new features and fixes

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/turnip/+git/turnip/+merge/394152
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/turnip:partial-py3-tests-runner into turnip:master.

diff --git a/Makefile b/Makefile
index 13d5c16..be2a3e1 100644
--- a/Makefile
+++ b/Makefile
@@ -94,7 +94,19 @@ lint: $(ENV)
 pip-check: $(ENV)
 	$(PIP) check
 
-check: pip-check test lint
+check: pip-check test lint check-python3-partial
+
+# This rule should be removed once all tests are running in python3.
+# Meanwhile, let's keep this list up-to-date and make sure we won't have
+# regressions.
+check-python3-partial:
+	$(MAKE) build VENV_ARGS="-p python3" ENV="$(PY3_ENV)"
+	$(PY3_ENV)/bin/python -m unittest \
+		turnip.pack.tests.test_helpers \
+		turnip.pack.tests.test_hookrpc \
+		turnip.pack.tests.test_http \
+		turnip.pack.tests.test_ssh \
+		turnip.pack.tests.test_functional.TestSmartSSHServiceFunctional
 
 check-python3:
 	$(MAKE) check VENV_ARGS="-p python3" ENV="$(PY3_ENV)"