launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~ilasc/turnip:make-repack-async into turnip:master

To: mp+394581@xxxxxxxxxxxxxxxxxx
From: Ioana Lasc <ioana.lasc@xxxxxxxxxxxxx>
Date: Tue, 01 Dec 2020 10:37:46 -0000
In-reply-to: <160648436288.12788.15088089312116342668.launchpad@ackee.canonical.com>
Reply-to: mp+394581@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Removed the comment in the unit test "test_repack" inside test_store.py. 
It turns out the test failure I was seeing Friday evening was still there today, it was a Python 3 incompatibility issue that's now fixed.

This MP is now ready for review with 2 design / requirements questions:
1. Is the "repack -Ad" all we want in the async version of the endpoint or do we want the other options back in ?
2. Do we want a different return on error ?
-- 
https://code.launchpad.net/~ilasc/turnip/+git/turnip/+merge/394581
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/turnip:make-repack-async into turnip:master.

References

[Merge] ~ilasc/turnip:make-repack-async into turnip:master
From: Ioana Lasc, 2020-11-27