launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/lib/lp/oci/model/ociregistrycredentials.py b/lib/lp/oci/model/ociregistrycredentials.py
> index 377dded..9980f48 100644
> --- a/lib/lp/oci/model/ociregistrycredentials.py
> +++ b/lib/lp/oci/model/ociregistrycredentials.py
> @@ -87,6 +87,10 @@ class OCIRegistryCredentials(Storm):
>  
>      _credentials = JSON(name="credentials", allow_none=True)
>  
> +    # The list of dict keys that should not be encrypted when storing
> +    # _credentials attribute.
> +    UNENCRYPTED_CREDENTIALS_FIELDS = ['username', 'region']

Let's give the name an initial underscore, since this is private to this class.

> +
>      def __init__(self, owner, url, credentials):
>          self.owner = owner
>          self.url = url


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/394703
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:oci-creds-store-unencrypted-fields.