launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~pappacena/launchpad:mirror-prober-untwist-db-calls into launchpad:master

To: "Thiago F. Pappacena" <pappacena@xxxxxxxxx>
From: Colin Watson <cjwatson@xxxxxxxxxxxxx>
Date: Wed, 02 Dec 2020 16:42:29 -0000
In-reply-to: <160633616255.24416.9608247522919951719.launchpad@ackee.canonical.com>
Reply-to: mp+394494@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

This is pretty difficult to follow, but I'm OK with it if it works.

However, did you consider instead using storm.twisted.transact for this?  It's designed for this sort of thing, and it might be possible to use it to make things significantly easier to follow.
-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/394494
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:mirror-prober-untwist-db-calls.

References

[Merge] ~pappacena/launchpad:mirror-prober-untwist-db-calls into launchpad:master
From: Thiago F. Pappacena, 2020-11-25