launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:testfix-stormify-xpph-queries into launchpad:master.

Commit message:
Fix query in MirrorDistroArchSeries.getLatestPublishingEntry

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/394881

I broke this by converting publishing history queries to Storm.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:testfix-stormify-xpph-queries into launchpad:master.

diff --git a/lib/lp/registry/model/distributionmirror.py b/lib/lp/registry/model/distributionmirror.py
index 11f2b13..5c5595e 100644
--- a/lib/lp/registry/model/distributionmirror.py
+++ b/lib/lp/registry/model/distributionmirror.py
@@ -848,8 +848,8 @@ class MirrorDistroArchSeries(SQLBase, _MirrorSeriesMixIn):
 
         if deb_only:
             clauses.extend([
-                BinaryPackagePublishingHistory.binarypackagerelease ==
-                    BinaryPackageFile.binarypackagerelease,
+                BinaryPackagePublishingHistory.binarypackagereleaseID ==
+                    BinaryPackageFile.binarypackagereleaseID,
                 BinaryPackageFile.filetype == BinaryPackageFileType.DEB,
                 ])