launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-bugtaskview-activity-and-comments into launchpad:master.

Commit message:
Fix BugTaskView.activity_and_comments for Python 3

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/394987

map() returns an iterator in Python 3 rather than a list.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-bugtaskview-activity-and-comments into launchpad:master.

diff --git a/lib/lp/bugs/browser/bugtask.py b/lib/lp/bugs/browser/bugtask.py
index c6bc9d7..66f2231 100644
--- a/lib/lp/bugs/browser/bugtask.py
+++ b/lib/lp/bugs/browser/bugtask.py
@@ -728,7 +728,7 @@ class BugTaskView(LaunchpadView, BugViewMixin, FeedsMixin):
             else:
                 return comment_event_dict(event_group)
 
-        events = map(event_dict, event_groups)
+        events = [event_dict(event_group) for event_group in event_groups]
 
         # Insert blanks if we're showing only a subset of the comment list.
         if self.visible_comments_truncated_for_display: