launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve

Looks mostly good to me, aside from the possible BugSummary issue I mentioned in https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/393460.

Diff comments:

> diff --git a/lib/lp/registry/interfaces/ociproject.py b/lib/lp/registry/interfaces/ociproject.py
> index 82ba8ad..a189654 100644
> --- a/lib/lp/registry/interfaces/ociproject.py
> +++ b/lib/lp/registry/interfaces/ociproject.py
> @@ -189,7 +202,8 @@ class IOCIProjectLegitimate(Interface):
>  @exported_as_webservice_entry(
>      publish_web_link=True, as_of="devel", singular_name="oci_project")
>  class IOCIProject(IOCIProjectView, IOCIProjectEdit,
> -                  IOCIProjectEditableAttributes, IOCIProjectLegitimate):
> +                  IOCIProjectEditableAttributes, IOCIProjectLegitimate,
> +                  IHasBugSupervisor, IHasExpirableBugs):

I'm not sure IHasExpirableBugs is quite right yet - you haven't edited lp.bugs.browser.buglisting.target_has_expirable_bugs_listing, at least.  Maybe that belongs in a separate MP?

>      """A project containing Open Container Initiative recipes."""
>  
>  


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/393570
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:stormify-bug-task.