launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-more-xmlrpc-proxy-bytes into launchpad:master.

Commit message:
Encode URL to bytes for twisted.web.xmlrpc.Proxy (again)

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/395292

Missed in 389759dcf38da9e1d2006dfcd2d46cb017f6e88e.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-more-xmlrpc-proxy-bytes into launchpad:master.

diff --git a/lib/lp/codehosting/sshserver/daemon.py b/lib/lp/codehosting/sshserver/daemon.py
index 3d6a429..a5ab6c5 100644
--- a/lib/lp/codehosting/sshserver/daemon.py
+++ b/lib/lp/codehosting/sshserver/daemon.py
@@ -104,6 +104,7 @@ def make_portal():
     avatars (see `CodehostingAvatar`).
     """
     authentication_proxy = Proxy(
-        config.codehosting.authentication_endpoint)
-    codehosting_proxy = Proxy(config.codehosting.codehosting_endpoint)
+        config.codehosting.authentication_endpoint.encode('UTF-8'))
+    codehosting_proxy = Proxy(
+        config.codehosting.codehosting_endpoint.encode('UTF-8'))
     return get_portal(authentication_proxy, codehosting_proxy)