launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/registry/model/ociproject.py b/lib/lp/registry/model/ociproject.py
> index 3b376be..d165572 100644
> --- a/lib/lp/registry/model/ociproject.py
> +++ b/lib/lp/registry/model/ociproject.py
> @@ -222,6 +222,16 @@ class OCIProject(BugTargetBase, StormBase):
>              if recipe is not None:
>                  recipe._official = True
>  
> +    def getDefaultGitRepository(self):
> +        namespace = getUtility(IGitNamespaceSet).get(
> +            self.registrant, oci_project=self)
> +        return namespace.getByName(self.name)
> +
> +    def getDefaultGitRepositoryPath(self):
> +        namespace = getUtility(IGitNamespaceSet).get(
> +            self.registrant, oci_project=self)
> +        return '%s/+git/%s' % (namespace.name, self.name)

Though on reflection I suppose the latter piece of this isn't really possible until we have official recipes, which is what this is working towards.  Still, it shouldn't be the OCI project's registrant.  Maybe the acting user (which should normally be passed down as a parameter from the view, rather than being detected in the model)?

> +
>  
>  @implementer(IOCIProjectSet)
>  class OCIProjectSet:


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/395174
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:oci-project-of-project-git-namespace.