launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/lp-signing:db-key-storage-type into lp-signing:master.

Commit message:
Add storage_type column to key

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers): db

For more details, see:
https://code.launchpad.net/~cjwatson/lp-signing/+git/lp-signing/+merge/395382

This will allow for storing private key material elsewhere than in the database.

Normally we ought to introduce this without a default, but I'd like to request a waiver of that in this case: we only have on the order of 20000 keys on production today, so I don't think rewriting the table should be a problem.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/lp-signing:db-key-storage-type into lp-signing:master.

diff --git a/migrations/patch-0-2-0-std.sql b/migrations/patch-0-2-0-std.sql
new file mode 100644
index 0000000..5ed2852
--- /dev/null
+++ b/migrations/patch-0-2-0-std.sql
@@ -0,0 +1 @@
+ALTER TABLE key ADD COLUMN storage_type integer DEFAULT 0 NOT NULL;