launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-captureoops into launchpad:master.

Commit message:
Fix CaptureOops for Python 3

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/395733

The AMQP sentinel needs to be bytes, not str.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-captureoops into launchpad:master.

diff --git a/lib/lp/testing/fixture.py b/lib/lp/testing/fixture.py
index ee9309e..0c1ff7a 100644
--- a/lib/lp/testing/fixture.py
+++ b/lib/lp/testing/fixture.py
@@ -254,7 +254,7 @@ class CaptureOops(Fixture):
         received over AMQP.
     """
 
-    AMQP_SENTINEL = "STOP NOW"
+    AMQP_SENTINEL = b"STOP NOW"
 
     def _setUp(self):
         self.oopses = []