launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/lib/lp/registry/templates/ociproject-index.pt b/lib/lp/registry/templates/ociproject-index.pt
> index 9a14cb7..e22e05c 100644
> --- a/lib/lp/registry/templates/ociproject-index.pt
> +++ b/lib/lp/registry/templates/ociproject-index.pt
> @@ -26,6 +26,24 @@
>    </metal:heading>
>  
>    <div metal:fill-slot="main">
> +    <div tal:condition="python: view.git_repository is None">
> +      <p>
> +        You can create a git repository for this OCI project in order to
> +        build your OCI recipes by using the following commands:
> +        <br />
> +        <pre class="command">
> +          git remote add origin git+ssh://<tal:name replace="view/user/name"/>@git.launchpad.net/<tal:name replace="view/git_repository_path"/>

This needs to somehow use the hostname part of the configured git backend (config.codehosting.git_ssh_root or so) rather than hardcoding git.launchpad.net.

> +          git push --set-upstream origin master
> +        </pre>
> +      </p>
> +    </div>
> +    <div tal:define="repo view/git_repository"
> +         tal:condition="repo">
> +      Your default git repository for this project is
> +      <a tal:content="repo/display_name"
> +         tal:attributes="href repo/fmt:url">lp:foo</a>.

Maybe just <a tal:replace="structure repo/fmt:link"/>?

> +    </div>
> +
>      <h2>OCI project information</h2>
>      <div class="two-column-list">
>        <dl id="pillar" tal:define="pillar context/pillar">


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/395174
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:oci-project-of-project-git-namespace.