← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~cjwatson/launchpad:py3-app-doctest-unicode-strings into launchpad:master

 

The proposal to merge ~cjwatson/launchpad:py3-app-doctest-unicode-strings into launchpad:master has been updated.

Description changed to:

There are loads of u'...' doctest examples in our test suite, and unfortunately I don't think any solution is better than just going through and making all of them bilingual.  In most cases the best option is to use print(), but occasionally something like the repr of six.ensure_str() works better in cases where we need a finer-grained test.

This is the first tranche of fixes for this pattern, beginning arbitrarily with lp.app.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/396328
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-app-doctest-unicode-strings into launchpad:master.


Follow ups