← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~ilasc/launchpad:bug-1910403 into launchpad:master

 

OK, now reproduced the exact same stack trace from the OOPS through unit test "testParseMaintainerNonASCII" and for the same reason captured by bug 1910403: non ASCII characters in the Maintainer field which will ultimately be a part of the email template parameters along with other fields in lp.services.mail.basemailer, line 185.

I would think we would see the same in the other test "testUploadWithoutNonASCII" -> this however is failing signature verification in the same points pasted in stack traces in my previous comments. I don't understand why it's failing differently there, but I also don't understand that area of the code enough yet and I'm probably not setting up the test correctly to begin with,
-- 
https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/396505
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/launchpad:bug-1910403 into launchpad:master.


References