launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-bound-methods-repr into launchpad:master.

Commit message:
Adjust tests for different repr of bound methods on Python 3

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/396919

FacetLink subclasses MenuLink, but doesn't override its render method.  On Python 2, that means that the repr of the render method of an instance of FacetLink is "<bound method FacetLink.render ...>", while on Python 3 the repr is "<bound method MenuLink.render ...>" instead.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-bound-methods-repr into launchpad:master.

diff --git a/lib/lp/services/webapp/doc/menus.txt b/lib/lp/services/webapp/doc/menus.txt
index e94d670..d2c1910 100644
--- a/lib/lp/services/webapp/doc/menus.txt
+++ b/lib/lp/services/webapp/doc/menus.txt
@@ -222,7 +222,7 @@ they are as we expect.
     menu: None
     name: foo
     path: /sesamestreet/+foo
-    render: <bound method FacetLink.render ...>
+    render: <bound method ...render ...>
     selected: False
     site: None
     sort_key: 0
@@ -240,7 +240,7 @@ they are as we expect.
     menu: None
     name: bar
     path: /sesamestreet/+bar
-    render: <bound method FacetLink.render ...>
+    render: <bound method ...render ...>
     selected: False
     site: None
     sort_key: 1