launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> 
> === modified file 'master.cfg'
> --- master.cfg	2021-01-07 09:32:46 +0000
> +++ master.cfg	2021-01-27 17:45:20 +0000
> @@ -76,44 +76,52 @@
>  
>  def addEnvironmentPrepSteps(fac, tree, container, variables=None):
>      fac.addStep(lpbuildbot.shell.ShellCommand(
> +        name="link-external-sourcecode",
>          command=['./utilities/link-external-sourcecode',
>                   '-p', "{}/dependencies".format(tree)],
>          description=['linking', 'dependencies'],
>          descriptionDone=['link', 'dependencies'],
>          workdir="{}/devel".format(tree)))
>      fac.addStep(lpbuildbot.shell.ShellCommand(
> +        name="update-sourcecode",
>          command=['./utilities/update-sourcecode', '--use-http'],
>          description=['pulling', 'new', 'sourcecode', 'revisions'],
>          descriptionDone=['pull', 'new', 'sourcecode', 'revisions'],
>          workdir="{}/devel".format(tree)))
>      fac.addStep(lpbuildbot.shell.ShellCommand(
> +        name="git pull download-cache",
>          command=['git', 'pull'],
>          description=['updating', 'download', 'cache'],
>          descriptionDone=['update', 'download', 'cache'],
>          workdir="{}/devel/download-cache".format(tree)))
>      fac.addStep(transfer.FileDownload(
> +        name="Download testr.conf",
>          mastersrc='testr.conf',
>          slavedest='.testr.conf',
>          mode=0o644,
>          workdir="{}/devel".format(tree)))
>      # Clean up any potential cruft left around by lxd from a previous run.
>      fac.addStep(lpbuildbot.shell.ShellCommand(
> +        name="lp-setup-lxd-cleanup",
>          command=['/usr/bin/lp-setup-lxd-cleanup', container],
>          description=['cleanup','previous','lxd','containers'],
>          descriptionDone=['cleaned','previous','lxd','containers'],
>          workdir="{}/devel".format(tree)))
>      fac.addStep(transfer.FileDownload(
> +        name="Downlad init_testr.py",

s/Downlad/Download/

>          mastersrc='scripts/init_testr.py',
>          slavedest='init_testr.py',
>          mode=0o544,
>          workdir="{}/devel".format(tree)))
>      fac.addStep(lpbuildbot.shell.ShellCommand(
> +        name="init_testr.py",
>          command=['./init_testr.py'],
>          description=['initializing', 'testrepository'],
>          descriptionDone=['initialized', 'testrepository'],
>          workdir="{}/devel".format(tree)))
>      # Make a temp dir, to work around bug 808557.
>      fac.addStep(lpbuildbot.shell.ShellCommand(
> +        name="make temp dir",
>          command=['mkdir', 'temp'],
>          workdir="{}/devel".format(tree)))
>      build_command = ['/usr/bin/lp-setup-lxd-build', container, tree]


-- 
https://code.launchpad.net/~twom/lpbuildbot/mattermost-notifier/+merge/397038
Your team Launchpad code reviewers is subscribed to branch lp:lpbuildbot.