launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-range into launchpad:master.

Commit message:
Don't assume range returns a list

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/397166
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-range into launchpad:master.

diff --git a/lib/lp/services/database/tests/test_collection.py b/lib/lp/services/database/tests/test_collection.py
index 8d38304..391f9b7 100644
--- a/lib/lp/services/database/tests/test_collection.py
+++ b/lib/lp/services/database/tests/test_collection.py
@@ -62,7 +62,7 @@ class CollectionTest(TestCaseWithFactory):
     def test_make_table(self):
         TestTable = make_table(1, 5)
         result = IStore(Person).find(TestTable).order_by(TestTable.id)
-        self.assertEqual(range(1, 5), get_ids(result))
+        self.assertEqual(list(range(1, 5)), get_ids(result))
 
     def test_select_one(self):
         TestTable = make_table(1, 5)