launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/launchpad:testfix-gunicornify-zope-config into launchpad:master.

Commit message:
Fixing broken gunicornify_zope_config_file test

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/397313
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:testfix-gunicornify-zope-config into launchpad:master.

diff --git a/lib/lp/scripts/tests/test_runlaunchpad.py b/lib/lp/scripts/tests/test_runlaunchpad.py
index 9587583..c310cde 100644
--- a/lib/lp/scripts/tests/test_runlaunchpad.py
+++ b/lib/lp/scripts/tests/test_runlaunchpad.py
@@ -232,8 +232,7 @@ class TestAppServerStart(lp.testing.TestCase):
             gunicornify_zope_config_file()
             self.assertEqual(2, mock_zope_config_file.call_count)
             new_file = mock_zope_config_file.call_args[0][0]
-            with open(new_file) as fd:
-                self.assertEqual(dedent("""
+            self.assertEqual(dedent("""
                 site-definition zcml/webapp.zcml
                 # With some comment
                 devmode off
@@ -245,4 +244,4 @@ class TestAppServerStart(lp.testing.TestCase):
                 </zodb>
 
 
-                """), fd.read())
+                """), new_file.read())