launchpad-reviewers team mailing list archive

[Tom Wardill <tom.wardill@xxxxxxxxxxxxx>]

Tom Wardill has proposed merging ~twom/launchpad:better-text-for-snap into launchpad:master.

Commit message:
Rename snap name field. LP: #1914233

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1914233 in Launchpad itself: "The different between snap name and store package name is not obvious"
  https://bugs.launchpad.net/launchpad/+bug/1914233

For more details, see:
https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/397362

Change the labels on the field so they're a bit clearer that this is not the name of the snap in the store.

https://people.canonical.com/~tomwardill/snap-name-rename.png
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~twom/launchpad:better-text-for-snap into launchpad:master.

diff --git a/lib/lp/snappy/interfaces/snap.py b/lib/lp/snappy/interfaces/snap.py
index eca689b..3835b23 100644
--- a/lib/lp/snappy/interfaces/snap.py
+++ b/lib/lp/snappy/interfaces/snap.py
@@ -667,9 +667,9 @@ class ISnapEditableAttributes(IHasOwner):
             "snapcraft.yaml.")))
 
     name = exported(TextLine(
-        title=_("Name"), required=True, readonly=False,
+        title=_("Snap recipe name"), required=True, readonly=False,
         constraint=name_validator,
-        description=_("The name of the snap package.")))
+        description=_("The name of the snap build recipe.")))
 
     description = exported(Text(
         title=_("Description"), required=False, readonly=False,