launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/launchpad:testfix-doctest-using-gunicorn into launchpad:master.

Commit message:
Fixing tests to use gunicorn definitions

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/397373
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:testfix-doctest-using-gunicorn into launchpad:master.

diff --git a/lib/lp/services/config/doc/canonical-config.txt b/lib/lp/services/config/doc/canonical-config.txt
index 91f676b..3b6af93 100644
--- a/lib/lp/services/config/doc/canonical-config.txt
+++ b/lib/lp/services/config/doc/canonical-config.txt
@@ -86,8 +86,13 @@ ZConfig.
     >>> config.devmode
     True
 
+    >>> config.use_gunicorn
+    True
+
+config.servers are only available when using Zope server (deprecated).
+
     >>> len(config.servers)
-    4
+    0
 
 
 Working with test configurations
diff --git a/lib/lp/services/webapp/doc/webapp-publication.txt b/lib/lp/services/webapp/doc/webapp-publication.txt
index 8be85b6..7329dbb 100644
--- a/lib/lp/services/webapp/doc/webapp-publication.txt
+++ b/lib/lp/services/webapp/doc/webapp-publication.txt
@@ -417,10 +417,10 @@ listens on a particular port.
 
 Find the port the Private XMLRPC service is listening on.
 
-    >>> for server in config.servers:
-    ...     if server.type == 'PrivateXMLRPC':
-    ...         private_port = server.address[1]
+    >>> config.use_gunicorn
+    True
 
+    >>> private_port = config.vhost.xmlrpc_private.private_port
     >>> print_request_and_publication(
     ...     'xmlrpc-private.launchpad.test', method='POST',
     ...     mime_type='application/xml')