launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-no-surrogates into launchpad:master.

Commit message:
Don't use a UTF-8 surrogate as a test URL

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/397523

The UTF-8 sequence ED B4 B5 encodes U+DD35, which is a surrogate; Python 3's UTF-8 decoder refuses to decode these.  Use a non-surrogate Unicode code point instead.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-no-surrogates into launchpad:master.

diff --git a/lib/lp/services/webapp/tests/test_publication.py b/lib/lp/services/webapp/tests/test_publication.py
index 7a539d4..60c7d94 100644
--- a/lib/lp/services/webapp/tests/test_publication.py
+++ b/lib/lp/services/webapp/tests/test_publication.py
@@ -299,7 +299,7 @@ class TestUnicodePath(TestCaseWithFactory):
         self.assertRaises(
             NotFound,
             browser.open,
-            'http://launchpad.test/%ED%B4%B5')
+            'http://launchpad.test/%EC%B4%B5')
         self.assertEqual(0, len(self.oopses))