launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> diff --git a/database/schema/patch-2210-26-0.sql b/database/schema/patch-2210-26-0.sql
> new file mode 100644
> index 0000000..9b919d6
> --- /dev/null
> +++ b/database/schema/patch-2210-26-0.sql
> @@ -0,0 +1,13 @@
> +-- Copyright 2016 Canonical Ltd.  This software is licensed under the
> +-- GNU Affero General Public License version 3 (see the file LICENSE).
> +
> +SET client_min_messages=ERROR;
> +
> +-- OCIRecipe privacy model is based only on ownership, similarly to Archives.
> +ALTER TABLE OCIRecipe ADD COLUMN private boolean DEFAULT false NOT NULL;

With regard to my comment on https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/397459, this should probably be information_type from the start.  And we'll probably want to fold OCIRecipeSubscription and the AccessArtifact stuff into this too.

> +
> +COMMENT ON COLUMN OCIRecipe.private
> +    IS 'Whether or not this OCI recipe is private.';
> +
> +
> +INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 26, 0);


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/397167
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:ocirecipe-private-dbpatch.