← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~ilasc/turnip:add-repack-data-notify into turnip:master

 

OK, I saw the commented-out os.chdir and assumed that the problem was at that level.

Rather than calling git count-objects in hookrpc, I think you should call it in the hook itself (turnip/pack/hooks/hook.py) and then send the relevant parts of the answer in the notify_push RPC call.  The hook already runs with the repository in question as its current directory.
-- 
https://code.launchpad.net/~ilasc/turnip/+git/turnip/+merge/397972
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/turnip:add-repack-data-notify into turnip:master.


References