launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-PackageUploadLog-rendering into launchpad:master.

Commit message:
Fix PackageUploadLog rendering for Python 3

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/398259

`DBItem.__str__` (invoked by `log/new_status` in TALES) isn't supposed to be permitted by the security proxy, although `unicode(item)` somehow seems to evade this on Python 2.  Use `log/new_status/title` instead.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-PackageUploadLog-rendering into launchpad:master.

diff --git a/lib/lp/soyuz/templates/distroseries-queue.pt b/lib/lp/soyuz/templates/distroseries-queue.pt
index 3850174..748e52d 100644
--- a/lib/lp/soyuz/templates/distroseries-queue.pt
+++ b/lib/lp/soyuz/templates/distroseries-queue.pt
@@ -156,7 +156,7 @@
                    style="border: 0"></td>
 
                <td colspan="8" style="border: 0">
-                 <span tal:content="log/new_status"></span>
+                 <span tal:content="log/new_status/title"></span>
                  <span tal:attributes="title log/date_created/fmt:datetime"
                        tal:content="log/date_created/fmt:displaydate" />
                  by <span tal:content="structure log/reviewer/fmt:link" />