launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/blueprints/model/specification.py b/lib/lp/blueprints/model/specification.py
> index e0d4001..55ce9d5 100644
> --- a/lib/lp/blueprints/model/specification.py
> +++ b/lib/lp/blueprints/model/specification.py
> @@ -755,7 +755,7 @@ class Specification(SQLBase, BugLinkTargetMixin, InformationTypeMixin):
>              # Grant the subscriber access if they can't see the
>              # specification.
>              service = getUtility(IService, 'sharing')
> -            _, _, _, shared_specs = service.getVisibleArtifacts(
> +            _, _, _, _, shared_specs = service.getVisibleArtifacts(

Before adding one more artifact type (for OCI, for example) we should refactor this getVisibleArtifacts method to return a dict or a named tuple. This is starting to be a bit too odd...

>                  person, specifications=[self], ignore_permissions=True)
>              if not shared_specs:
>                  service.ensureAccessGrants(


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/398318
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:snap-pillar-subscribe-removal-job into launchpad:master.